Craig MacKenzie

Results 244 comments of Craig MacKenzie

Yes, I had planned to put this in 8.5.1. We are waiting for the 8.5.0 release to occur before back porting, as we are still generating 8.5.0 build candidates due...

@fearful-symmetry I've added the label to create the 8.5.0 backport, we are good to backport for inclusion in 8.5.1 now.

Logstash test failure again: ``` [2022-09-29T21:41:19.999Z] === Failed [2022-09-29T21:41:19.999Z] === FAIL: metricbeat/module/logstash TestFetch/node_stats (0.12s) [2022-09-29T21:41:19.999Z] logstash_integration_test.go:53: [2022-09-29T21:41:19.999Z] Error Trace: logstash_integration_test.go:53 [2022-09-29T21:41:19.999Z] Error: Should NOT be empty, but was [] [2022-09-29T21:41:19.999Z]...

We need to either fix or disable this Logstash integration test to avoid intermittent build failures.

Looks good to me, having this test (and the more advanced tests) will be really valuable. Thanks!

Related, https://github.com/elastic/elastic-agent-shipper/issues/60 to write the first basic test that communicates with the shipper binary. Could also be done as part of this issue depending on progress and the order things...

~Actually, looks like this covers https://github.com/elastic/elastic-agent-shipper/issues/60 already. Closing that one as a duplicate.~

~Switching assignee to @faec like elastic/elastic-agent-shipper#60 was to start.~

Re-reading this issue it is written to test filebeat (or any beat really) communicating with the shipper. We should do this but we can start with something simpler like elastic/elastic-agent-shipper#60...

Let's write one simple test first as described in elastic/elastic-agent-shipper#60 that doesn't require using the beat shipper client for simplicity, and then follow up with this more complex set of...