Christian Luhmann

R hat not showing in plot_forest?

4

**Describe the bug** When `plot_forest` is called with pymc-created InferenceData and `r_hat=True`, a subplot is created but the R hat values are not visible. **To Reproduce** ```python import pymc as...

Doc string terminology for unnamed distributions created via .dist()

8

When updating the docstrings for `pm.AR()` distribution class (https://github.com/pymc-devs/pymc/pull/6080), it became clear that we have no clean, unified way to refer to the "unnamed distribution" arguments taken by some distributions...

Problems in (high impact) GLM Hierarchical notebook

3

**Notebook title**:GLM: Hierarchical Linear Regression **Notebook url**: [source link](https://github.com/pymc-devs/pymc-examples/blob/main/examples/generalized_linear_models/GLM-hierarchical.ipynb), [website link](https://www.pymc.io/projects/examples/en/latest/generalized_linear_models/GLM-hierarchical.html) ## Issue description There are many, many divergences in the sample of the main, hierarchical model. There also appear...

DOC: Summarize best practices

1

### Idea or request for content: I think it would be good to have a set of best practices and/or practices that are "intuitive" but not ideal. The sorts of...

Broken link in MLDA example notebook

1

**Notebook title**: The MLDA sampler **Notebook url**: https://www.pymc.io/projects/examples/en/latest/samplers/MLDA_simple_linear_regression.html ## Issue description The notebook contains this text: > The model is similar to the one used in https://docs.pymc.io/notebooks/GLM-linear.html. But the URL...

Broken link in MLDA intro page

4

**Notebook title**: MLDA sampler: Introduction and resources **Notebook url**: https://www.pymc.io/projects/examples/en/latest/samplers/MLDA_introduction.html ## Issue description Under the ["Notebooks with example code" section](https://www.pymc.io/projects/examples/en/latest/samplers/MLDA_introduction.html#notebooks-with-example-code), the "Variance 2" (external) link is broken. ## Proposed solution...

I noticed that the signatures of the `az.InferenceData.to_netcdf()` method and the `az.to_netcdf()` methods are not entirely aligned. For example, `az.InferenceData.to_netcdf()` takes a boolean `compress` argument which is absent in the...

Doc formatting is broken in various places/ways

4

The list of methods for the MMM module is squashed horizontally. Many methods have long names, but I am not sure this is the problem. I am viewing on a...

Remove unnecessary calls to PyTensor eval() from user-facing methods

17

Fixes https://github.com/pymc-labs/pymc-marketing/issues/383. The calls to `eval()` have been moved out of the `BaseDelayedSaturatedMMM.channel_contributions_forward_pass()` method and to user-facing methods in `DelayedSaturatedMMM` . It is not entirely clear to me whether `get_channel_contributions_forward_pass_grid()`...

Avoid PyTensor evals whenever possible

3

In `BaseDelayedSaturatedMMM`, the `channel_contributions_forward_pass()` method calls `eval()` on the pytensor value to be returned ([here](https://github.com/pymc-labs/pymc-marketing/blob/3a9db517d1d3c5a930eeb80ad24c540382d1bc33/pymc_marketing/mmm/delayed_saturated_mmm.py#L386)). This causes problems if you expect the tensor returned by the various transformation methods to...