clubby789

Results 42 comments of clubby789

Can you give an example of input/settings/output?

Making TLS work would probably require refactoring the `Listener` and `Connection` traits to not expect IP-based listeners

Seems to be caused by https://stdrs.dev/nightly/x86_64-unknown-linux-gnu/src/std/sys/unix/fs.rs.html#157-160. The stdlib calls `statx` will a NULL pointer to check if the syscall is available. It seems to have been fixed in upstream Valgrind...

I did end up making my own structure with a copy, but it took me a while to sort out lifetimes because `InsnDetail` references rather than copying the original `cs_detail`....

The status of my PR? As far as I'm aware it's fully working, and I'm waiting on a maintainer to review it

I opted to remove the unsafe block completely and use `swap_with_slice` - when building in release the assertion is removed completely so the generated code is the same.

I'm not very experienced with benchmarking but the differences seem negligible: PR: ``` test add_100_edges_to_self ... bench: 255 ns/iter (+/- 15) test add_100_nodes ... bench: 13,001 ns/iter (+/- 544) test...

I switched to using the method suggested by @saethlin since the fully-safe method adds a lot of complexity to the code, and it looks like the bounds checks aren't fully...

Why does this fix it? Are you running your own one?

I notice that even when the type is known and this isn't an issue (e.g) ```rs fn main() { let b = Box::new("abc"); let ptr = b.into_raw(); } ``` Applying...