Patrick Cloke comments

Results 339 comments of


                                            Patrick Cloke

MSC4175: Profile field for user time zone

This has a couple of implementations and has proven useful already. I think it is reasonable and doesn't have too much room for abuse. @mscbot fcp merge

MSC4175: Profile field for user time zone

I finished the couple missing bits in the checklist. Thank you for remembering to post!

`GET /_matrix/federation/v1/query/profile` response violates OpenAPI schema

I think the client-server API is fixed in the unstable version that are disabled by default.

Celery Beat daemonization with systemd (clarify docs?)

(Not a maintainer, but I've contributed some stuff previously.) I'd suggest going ahead and putting up a PR to add this documentation. It'd also be awesome to get the warnings...

MSC3572: Relation aggregation cleanup

Although I agree it is unfortunate that `unsigned` has a mixed of namespaced and unnamespaced parameters I do not think it is worth the churn to remove the prefix. Additionally,...

@cachedList can insert None instead of absence of a key

It could probably use a sentinel instead of None to know if it uncached?

@cachedList can insert None instead of absence of a key

Maybe the mypy plugin is missing this coercion?

@cachedList can insert None instead of absence of a key

https://github.com/element-hq/synapse/blob/51dd4df0a317330d0679e48d7a6dcd5abb054ec7/scripts-dev/mypy_synapse_plugin.py#L51-L57C20 That should probably handle `cachedList` too?

MSC3389: Relation redactions

Synapse implementation: https://github.com/matrix-org/synapse/pull/15565

MSC4155: Invite filtering

@mscbot concern Confusing behavior of whether enforced by clients or servers