Patrick Cloke

Results 339 comments of Patrick Cloke

Sorry for the delay. I pushed a bunch of changes which heavily simplifies the code. If we want something similar to `TemplateResponse`, that's best done as a separate PR.

> Fixes DRF schema generation for a serializer which contains a field using QuerySetSequence. Should there be a test for this and not just the proxy model tests?

> What happens to the buffered tasks in case of a shutdown (like sending a signal to kill a pod)? Do they go back into the queue? It somewhat depends...

Is this a code issue or a type hint issue? Does the code in the README not work?

Yes, definitely should be fixed. Luckily we don't export type hints yet. If you have time to make a PR that would be great.

I think that would be OK, it should probably be named `render_block` to match [`render`](https://github.com/django/django/blob/7adb6dd98d50a238f3eca8c15b16b5aec12575fd/django/shortcuts.py#L18-L26) vs `render_to_string`? (`render_to_response` is part of the view classes IIRC and not a standalone function.)...

It's still on my to do list, I've unfortunately been fairly busy. Will get to it eventually. Sorry for the delay.

This is due to the [historical user names](https://spec.matrix.org/v1.11/appendices/#historical-user-ids) that were previously used.

> Well, empty user names could be considered a nogo even in historical usernames? They do exist though. [MSC4044](https://github.com/matrix-org/matrix-spec-proposals/pull/4044) aims to improve this.