Patrick Cloke

Results 263 comments of Patrick Cloke

"doesn't equate to adding them as a contact" is a bug that we've wanted fixed for a long time. It should be trivial to implement, but doesn't make much sense...

Some of the UI is [shared](https://dxr.mozilla.org/comm-central/source/chat/content), it might be beneficial to unfork some other parts if it helps this extension. (That's wanted regardless.)

Are you sure about this? It seems like it would be reasonable for someone to remove an extension, then want it back in the future and expect all their settings...

celery-batches unfortunately doesn't provide all the signals that normal Celery tasks do (see #33 for an example). I suspect this is why you're not seeing it appear properly in flower....

> >Task requests are buffered in memory (on a worker) until either the flush count or flush interval is reached. > > Does it mean that Task requests are buffered...

> Oh, I see - the plugin sends Task immediately to the broker, then a worker get a task from the queue but doesn't execute the "business" code until `flush_interval`...

> One more question left - the flow will be broken when we run three "main" workers on different physical nodes or three workers in the same node, as documentation...

> I think we can add How does it work section in README.md and add a link to this issue :D It explains everything. I think this should get distilled...

> The problem is that when Celery receives a SIGTERM (from Kubernetes for instance), in prefork, it doesn't wait for the tread timer to execute before terminating. I haven't run...

> > I think you're just asking "what happens if I restarted the worker while using this package?" -- I suspect whatever is in the queue (so a maximum of...