clock999

Results 23 comments of clock999

Failed to compile the source code

HI, This is the link where I downloaded the source: https://jaist.dl.sourceforge.net/project/bashdb/remake/4.3%2Bdbg-1.5/remake-4.3%2Bdbg-1.5.tar.gz. My steps are just simple. > cd to remake-4.3+dbg-1.5 >./configure >make But I met the errors: src/main.o: In function...

Failed to compile the source code

The os is ubuntu 16.04.

fix #5591: Add check for meaningless comma operator in if statement, misplaced ')'

Hi CHR, many thanks for your comments, and I have updated the commit. But there is a failed case tested on the github for the commit, that seems not the...

fix #5591: Add check for meaningless comma operator in if statement, misplaced ')'

> I also want to point out that misra has a rule that forbids comma operators. But I still feel sympathy for this checker if we make it more specific...

fix #5591: Add check for meaningless comma operator in if statement, misplaced ')'

> ``` > lib/checkother.cpp:4384:50: style: Call to 'Token::previous()' followed by 'Token::link()' can be simplified. [redundantNextPrevious] > const Function * func = tok->previous()->link()->previous()->function(); > ``` > > Use `tok->linkAt(-1)->previous()->function()` instead. Hi...

fix #5591: Add check for meaningless comma operator in if statement, misplaced ')'

> I feel that it would be good to run test-my-pr.py script and investigate if the warnings look correct.. Hi Danmar, while running the test-my-pr.py, there is a problem. The...

fix #5591: Add check for meaningless comma operator in if statement, misplaced ')'

> @clock999 thanks! Sometimes old builds mess it up because the script uses different build flags etc.. so if you remove the build folder and all old *.o files etc...

fix #5591: Add check for meaningless comma operator in if statement, misplaced ')'

> I have executed test-my-pr.py > > I got some warnings in Poppler project for such code: > > ``` > if (obj = parser->getObj(true), !obj.isInt()) { > ``` >...

fix #5591: Add check for meaningless comma operator in if statement, misplaced ')'

Hi Danmar, I checked the package Poppler and some of the downloaded packages with the updated commit, but I have not run the script test-my-pr.py for all the packages. I...

fix #5591: Add check for meaningless comma operator in if statement, misplaced ')'

HI Danmar, Sorry, it is a little long time since the comment posted. As this ticket #5591 is not a explicit bug, and it is something like predicting the possible...