clock999

> > yes.. if we can unify logic that would make me happy.. :-) > > Working on it... Hi firewave, If it is ok, I’d like to complish this...

> @clock999 sorry for late response. do you want to continue working on this? I would like that we have consistent proper behavior when --max-configs is used. Hi Danmar, Yes,...

I think maybe we should remove Settings::checkAllConfigurations. Maybe GUI should only accept the raw user input to set the Settings, but not edit the Settings. As I understand, the values...

I updated an original version, and will update it further.

Hi Danmar, ``` // If importing a project, only check the given configuration if (!mProjectFile->getImportProject().isEmpty()) settings.checkAllConfigurations = false; ``` While setting the checkAllConfigurations, I see there is a comment "If...

Hi Danmar, I write the details the unit test case below. So it is easy for the discussion. Under the folder named 'helloworld', there are main.cpp, test.cppcheck and compile_commands.json. main.cpp:...

Hi Danmar, I think we have 3 ways to have user defined configs. > using -D in the command line > using the defines tag in the .cppcheck file >...

Hi Danmar, Many thanks for your time with the comments for correcting my submit, that really help me a lot! For this PR, I summarized the logic as below. >...

Hi Danmar, Suppose we have below scenary. compile_commands.json: ``` [ { "directory": "helloworld", "command": "/usr/bin/c++ -o CMakeFiles/main.dir/main.cpp.o -c helloworld/main.cpp", "file": "helloworld/main.cpp", "output": "CMakeFiles/main.dir/main.cpp.o" } ] ``` test.cppcheck ``` ./compile_commands.json ```...

Hi Danmar, I updated the commit. ``` the user_defined_configs are the configs in the imported files including compile_commands.json combined with the ones from the '-D' option with compile_commands.json imported, with...