Claudio Fantacci comments

Results 53 comments of


                                            Claudio Fantacci

Decide at which level an user can interact/command the class composing a filter

PS ```cpp else if (property == "get_contact_state") { return (tactile_data_size_ > 0); outcome &= true; //

Decide at which level an user can interact/command the class composing a filter

I'll try to give `set_property` and `get_property` a shot and see how it goes. Not sure I will be happy about it though 🤣

How shold we implement the state?

A possible implementation is https://github.com/sfwa/ukf/blob/master/include/UKF/StateVector.h

Avoid (or not) default implementation of method `MeasurementModel::getNoiseCovarianceMatrix`

I don't like this as well. We should just throw an exception here and in similar contexts.

Double check protected data member

The current library rework is addressing this. The main problem seems related to `GaussianMixture` and derived classes where we need to carefully think about the consequences of this change.

Double check protected data member

To date, if you change the scope of ```cpp unsigned int num_particle_; std::size_t state_size_; ParticleSet pred_particle_; ParticleSet cor_particle_; ``` in `SIS.h` it becomes difficult to inherit from it (obviously, we...

Gaussian blur cpu performance

Hi @mgoulao, thanks for reaching out! Yeah indeed I've also tested this and is not performing quite well on CPU. Transferring the image to CPU only helps a little, it's...

Gaussian blur cpu performance

Thanks for reporting this as well! I'm a bit short of time at the moment, and for the whole October I'm afraid. I'll try to have a look asap, or...

Gaussian blur cpu performance

Thanks @ASEM000, I'll have a look at it as soon as I can, unfortunately that will probably be end of month 😭

Gaussian blur cpu performance

I just skimmed through the code, so without checking the implementation details. When you say `kex` there, you mean **the new implementation** which is without `kex` or extra dependency. Is...