Christian Clason

Results 1361 comments of Christian Clason

Should this be gated behind the `spell` option? I'd hate to pay a performance penalty while spelling wasn't even enabled 😬

I'm not going to comment on the technical part (although the argument "spell ~ highlight" appears sound to me and appeals to the precedent of `conceal` -- the performance argument...

> Downstream only has to consider the primary query method, be it spell.scm or highlights.scm. Yes, _if_ there is a clear primary method. Otherwise it will become a free-for-all. Also,...

If this is still relevant after the recent changes, can you rebase and update (or close otherwise)?

Is this related or can be repurposed: https://github.com/neovim/neovim/pull/15248?

Couldn't this be an option to `get_viewport`, controlling how to count virtual lines?

OK, that does indeed sound like an orthogonal problem. Thanks for the explanation!

I've pared this down to a more minimal (not configurable) component that may be more appropriate for express line: https://gist.github.com/clason/1fe0f77ed3cc810ff75429edf1c56409

Yeah, I understand that completely. For me, it's about 1.3ms out of 50ms -- not at all terrible, but the largest single time for a plugin without configuration (beating even...