Christian Clason
Christian Clason
@MDeiml What is the status here? Is this ready for review, or is there something left to be done (e.g., tests)? @neovim/treesitter
Lint disagrees :D
Then you need to rebase on master to shut them up ;)
Protip: run `stylua runtime/` before committing. (But no need to do that now; let's wait for actual review.)
But you could take a look at https://github.com/neovim/neovim/pull/18232 whether any of those upstreamed functions would be useful here. I'd also like to combine the `get_node_text` refactor (to homogenize with nvim-treesitter)...
Breaks the `lsp_spec` tests as well (presumably due to the fake file names) ...
Yeah, that's not gonna work. Leaving this open for a bit in case anybody has any idea how to teach the fake server to handle valid URIs, otherwise not much...
@justinmk you might be interested in https://github.com/nanotee/nvim-lua-guide
> wow that looks good actually. Also a reminder that our docs could be more accessible if their HTML form was improved... I do think that would be worth someone...
Yes, that's what I was getting at. See the comments at the other PR, especially https://github.com/neovim/neovim/pull/16219#issuecomment-958969904.