Clare So comments

Results 14 comments of


                                            Clare So

Refactor FXIOS-22527 - UI Tests Added waitAndTap() for better maintenance

Smoke tests look good: https://app.bitrise.io/app/6c06d3a40422d10f/pipelines/e12a5a6f-d309-4a7b-9fb9-a10d82445c93 L10n tests also look good. I would approve 👍🏼 this PR.

Refactor FXIOS-12796 [Swift 6 Migration] Fix main actor isolation warnings that are Swift 6 errors in the XCUITests suite - Batch 3

> > 🚫 SwiftUI 'Text(""' in file firefox-ios/firefox-ios-tests/Tests/XCUITests/C_AddressesTests.swift at line 683 needs to be avoided, use Strings.swift localization instead. Yes, I have encountered the same type of error from Danger,...

Lock icon does not appear on awesome bar for untrusted connection

I've confirmed that the regression occurs since this PR: https://github.com/mozilla-mobile/firefox-ios/pull/22474. @mattreaganmozilla

Remove FXIOS-14370 [Toolbar] Clean up TabToolbar

I can reproduce the test failures reported on Bitrise. On iPhone only: There's a split second that the toolbar isn't visible when the test attempts to navigate to private mode.