Remove FXIOS-14370 [Toolbar] Clean up TabToolbar

[thatswinnie]

:scroll: Tickets

Jira ticket Github issue

:bulb: Description

Clean up TabToolbar from old toolbar.

:pencil: Checklist

• [x] I filled in the ticket numbers and a description of my work
• [x] I updated the PR name to follow our PR naming guidelines
• [ ] I ensured unit tests pass and wrote tests for new code
• [ ] If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
• [ ] If adding telemetry, I read the data stewardship requirements and will request a data review
• [ ] If adding or modifying strings, I read the guidelines and will request a string review from l10n
• [ ] If needed, I updated documentation and added comments to complex code

[mobiletest-ci-bot]

	Messages
:book:	Project coverage: 38.03%

✍️ Strings Updated

Detected changes in Shared/Strings.swift. To keep strings up to standards, please add a member of the firefox-ios-l10n team as reviewer. 🌍

💪 Quality guardian

3 tests files modified. You're a champion of test coverage! 🚀

🏔️ Summit Climber

This PR is a big climb with 1365 lines changed! Thanks for taking on the heavy lifting 💪. Reviewers: a quick overview or walkthrough will make the ascent smoother.

🎉 BrowserViewController got smaller

Nice! BrowserViewController.swift got smaller by 41 lines.

❌ Per-file test coverage gate

The following changed file(s) are below 35.0% coverage:

File	Coverage	Required
firefox-ios/Client/Frontend/Browser/BrowserViewController/Extensions/BrowserViewController+ToolBarActionMenuDelegate.swift	6.0%	35.0%

Client.app: Coverage: 37.12

File	Coverage
BrowserViewController.swift	29.22%	⚠️
TopTabsViewController.swift	21.52%	⚠️
PhotonActionSheetView.swift	0.0%	⚠️
BrowserViewController+ToolBarActionMenuDelegate.swift	5.97%	⚠️
OverlayModeManager.swift	88.64%	✅
SingleActionViewModel.swift	48.0%	⚠️
TabTrayViewController.swift	49.51%	⚠️
PrivateModeButton.swift	81.82%	✅

Generated by :no_entry_sign: Danger Swift against 3f497aa3147078ab99c0078cfc430ffbed0eed28

[clarmso]

I can reproduce the test failures reported on Bitrise.

On iPhone only: There's a split second that the toolbar isn't visible when the test attempts to navigate to private mode.

[mergify[bot]]

This pull request has conflicts when rebasing. Could you fix it @thatswinnie? 🙏

[mergify[bot]]

This pull request has conflicts when rebasing. Could you fix it @thatswinnie? 🙏

[github-actions[bot]]

🚀 PR merged to main, targeting version: 147.0