firefox-ios icon indicating copy to clipboard operation
firefox-ios copied to clipboard

Lock icon does not appear on awesome bar for untrusted connection

Open clarmso opened this issue 1 year ago • 5 comments

Steps to reproduce

  1. Open www.badssl.com
  2. Tap "Expired" under "Certificate".
  3. Wait until the page load.
  4. Look for the lock icon next to the URL.

See XCUITests/TrackingProtectionTests/testLockIconSecureConnection

I can reproduce the issue manually

Expected behavior

On release/v132, the slashed lock icon is present: Simulator Screenshot - iPhone 15 - 2024-10-16 at 15 05 09

Actual behavior

No lock icon is seen: Simulator Screenshot - iPhone 15 - 2024-10-16 at 14 51 08

Device & build information

  • Device: iPhone 15 simulator
  • Build version: main
  • First seen version: Oct 14 (https://github.com/mozilla-mobile/firefox-ios/pull/22474)

Notes

Attachments:

┆Issue is synchronized with this Jira Task

clarmso avatar Oct 16 '24 19:10 clarmso

➤ Norberto Andres Furlan commented:

Alexandru Farcasanu can you check this one? Can it be related to any change on Unified Panel?

data-sync-user avatar Oct 17 '24 19:10 data-sync-user

➤ Norberto Andres Furlan commented:

Andrei Bodea for visibility.

data-sync-user avatar Oct 17 '24 19:10 data-sync-user

I've confirmed that the regression occurs since this PR: https://github.com/mozilla-mobile/firefox-ios/pull/22474. @mattreaganmozilla

clarmso avatar Oct 17 '24 20:10 clarmso

I self-assigned this ticket, will take a look as soon as I have a chance. We need to be careful that whatever fix is implemented for this does not regress the security fix added for https://mozilla-hub.atlassian.net/browse/FXIOS-7328.

mattreaganmozilla avatar Oct 17 '24 21:10 mattreaganmozilla

➤ Andrei Bodea commented:

Thanks, Norberto Andres Furlanwill keep an eye on this.

data-sync-user avatar Oct 18 '24 11:10 data-sync-user

➤ Andrei Bodea commented:

Verified as fixed on v133 (47401) with iPhone 15 Pro (18.2).

data-sync-user avatar Nov 12 '24 14:11 data-sync-user