Christian Kadluba

Results 72 comments of Christian Kadluba

Thank you for reporting this. Is it possible for you to send us a pull request including tests?

When using the batched sink (`WriteTo`) there is a big caveat whith wrong input data. If one log event in a batch cannot be written to the database, then the...

Message trimming can be used to avoid this case. Closing this issue.

Hi @Dowlatabadi! Thank you for your contribution. :) It looks quite good but I made a review and had some comments. Please add the necessary changes. Do you have some...

I will close this long standing PR. We are currently upgrading SqlClient in PR #418 and will remove the obsolete MS AppAuthentication soon and use SqlClient auth capabilities instead. Thanks...

Sounds very interesting. Do I understand this right, that the application specific id is used to find the matching delegate when a property is rendered? If the rendering delegate could...

Hi, and sorry for the late answer. This sounds like a very useful enhancement. I will consider it but cannot make any promise at the moment. In the meantime we...

After rethinking this I came to the following concusions. File and console are just serial streams of data. This is why those sinks need to format each log event according...

@flipdoubt I see your point. Unfortunately the quotes around the property names are not generated in MSSQL sink but in the serilog core (https://github.com/serilog/serilog/blob/24d623769fd7a00b348af3dac0b875bf23b3aea5/src/Serilog/Events/ScalarValue.cs#L69). Passing your own custom `ITextFormatter logEventFormatter`...

Can you show a full sample of the log call that creates your log event containing the `"Job #{JobNumber} generated Invoice #{InvoiceNumber}"` message?