Automated-Fact-Checking-Resources icon indicating copy to clipboard operation
Automated-Fact-Checking-Resources copied to clipboard

Update dependencies and obsolete built in Azure Authentication

Open Daniel-Svensson opened this issue 3 years ago • 2 comments

  • Update Microsoft.Data.SqlClient to fix #374 and fix #302 and make Azure Active Directory authentication possible to do by just passing in the correct connection string (same problem PR #354 wanted to solve)

  • Obsoletes properties for the build in Azure Active Directory authentication support since the same can be accomplished using connection string (which also support a few more scenarios)

  • Update most of the other dependencies to the latest version so that the latest version of the batching sink gets used (which cotained https://github.com/serilog/serilog-sinks-periodicbatching/issues/52 and maybe some more )

  • Update all nugets for AppConfigDemo since I needed to update some of them

Daniel-Svensson avatar Jan 25 '22 19:01 Daniel-Svensson

@ckadluba I did not touch net452, since it sounded like you want to keep it at least till April when it stops receiving security fixes.

I have not been able to test the net452 target it since it is no longer supported in Visual Studio 2022.

Daniel-Svensson avatar Jan 25 '22 19:01 Daniel-Svensson

You should probably be able to also remove the "### .NET Framework apps must reference Microsoft.Data.SqlClient" section from the readme since the issues mentioned should have been fixed in Microsoft.Data 2.1. I have not verified both so I did not touch the text

Daniel-Svensson avatar Jan 25 '22 19:01 Daniel-Svensson

I will close this long standing PR. We are currently upgrading SqlClient in PR #418 and will remove the obsolete MS AppAuthentication soon and use SqlClient auth capabilities instead.

Thanks a lot for your input and research.

ckadluba avatar Sep 26 '22 06:09 ckadluba