CJ Yetman comments

Results 213 comments of


                                            CJ Yetman

PACTA erroneously incuding short positions

PACTA team, in my interpretation, gave the green light for this in the meantime, though it still may be a debate/question in the future.

PACTA erroneously incuding short positions

I believe it was "official" enough.

ST is missing columns (sub)sector_ipr from processed input portfolio

@jacobvjk is this still a valid issue?

Change the mapped sector of the company fin data

this will probably be dealt with here 2DegreesInvesting/data_preparation/issues/14

extend styler action to R files not in R directory

yeah, I guess I was wondering if it's possible without that nuclear option, but in the long run that's probably what needs to happen

bonds and equity with valid_input==FALSE

I don't even remember why this was a concern, but it does seem to still be happening, even though it was supposedly resolved according to https://github.com/2DegreesInvesting/PACTA_analysis/issues/17#issuecomment-611549921 @Clare2D is this a...

bonds and equity with valid_input==FALSE

flag?

bonds and equity with valid_input==FALSE

using current master 926d584eafd2d07c32017cf580dede5195775773 ```r library(dplyr) source("web_tool_script_1.R") file.path('working_dir/30_Processed_Inputs/TestPortfolio_Input/audit_file.rda') %>% readRDS() %>% as_tibble() %>% filter(asset_type %in% c('Bonds', 'Equity')) %>% filter(valid_input == FALSE) %>% select(investor_name, portfolio_name, holding_id, isin, value_usd, asset_type, valid_input, flag)...

Check required for normalisation of Fund Data

I assume this is largely related to #368?

remove `map_security_sectors()` once its purpose is shifted to 2DegreesInvesting/data_preparation

This is also relevant to the refactoring happening in #247