CJ Yetman
CJ Yetman
I would not suggest using the `+`. Sorry, I introduced that to the conversation. I think it's probably a fairly common thing for people to have data like... | international_code...
My take on the North American Numbering Plan is that it is a sub-international (E.164) numbering plan, so technically the international calling code (E.164) is "1" for all of the...
Here's a start... ``` r library(tabulizer) library(dplyr) library(countrycode) extract_tables('https://www.itu.int/dms_pub/itu-t/opb/sp/T-SP-E.164D-11-2011-PDF-E.pdf', pages = 3:9, output = "data.frame") %>% bind_rows() %>% as_tibble() %>% rename(code = 1, country = 2) %>% filter(!is.na(code)) %>% filter(!country...
Here's a better version using the 2016 version of codes found [here](https://www.itu.int/pub/T-SP-E.164D-2016). Unfortunately, they only have PDF or DOCX versions... neither of which is ideal for our purposes. ``` library(tabulizer)...
Yeah, I get the appeal of regex, and it can catch lots of variations... but I worry about the things that it can catch that were unexpected or unanticipated. Like...
I agree with you about the intended design, and that not including matching within sentences... but it has been mentioned before, e.g. #162. Personally, I never liked that idea much...
One more related/underlying question... do we have a preference for avoiding false positives or false negatives? Seems like avoiding false positives fits in with the philosophy elsewhere (like preferring exact,...
Should this be closed since it's not exactly an open issue, though the conversation above is certainly important and relevant going forward?
On [line 63](https://github.com/vincentarelbundock/countrycode/blob/master/R/countrycode.R#L163), we force the `sourcevar` vector to be in all caps to achieve case-insensitive matching, but that's with the assumption/insistence that all non-regex origin codes in `codelist` are...
wrt `pkgdown`, I think that would be cool, and it's pretty easy to setup/manage