Chris Jerdonek

Results 119 comments of Chris Jerdonek
trafficstars

Another option could be to, inside `is_invalid_params()`, create a function on the fly with the same signature as obtained by `inspect.getargspec(func)` but with empty body `pass`. Then you could invoke...

> @cjerdonek application is supposed to raise exceptions, inherited from JSONRPCDispatchException, so the manager could show a proper message. Okay, I was more referring to the case that arises if...

@pavlov99 Thanks for such a prompt reply. It seems to me though that json-rpc has a responsibility to meet its guarantee and return valid JSON. Every application is susceptible to...

Another suggestion: if you are concerned about backwards-forwards compatibility, etc, how about handling the serialization exception and raising a serializable exception saying something like, "unserializable error raised with type: ..."?...

For the record, I just want to include this from the [JSON-RPC 2.0 Specification](http://www.jsonrpc.org/specification#response_object), section 5 Response object: > When a rpc call is made, the Server MUST reply with...

@shimizukawa Can my patch submission be found somewhere?

This doesn't seem ideal, but might another possible approach be to set a timeout _inside_ the app that is a bit shorter than the gunicorn timeout, and then log the...

I wonder if an old version of `urllib3` was being used. It seems `urllib3` fixed it not to show "TypeError: getresponse() got an unexpected keyword argument 'buffering'" starting with `urllib3`...

(I don't think I clicked anything to unassign @ashwoods, btw.)

> I haven't found anything like this in pygit2 or libgit2's issue tracker or release notes. It's conceivable this issue is due to the following libgit2 issue, which was resolved...