Chris Jerdonek

Results 116 comments of Chris Jerdonek
trafficstars

Shouldn't this be labeled a bug rather than an enhancement? docker-osx-dev unexpectedly doesn't sync directories that .dockerignore says to include. It's possible that full parity might not be achievable, but...

FYI, erroring out or prompting at a missing file would break @brikis98's suggestion [here](https://github.com/brikis98/docker-osx-dev/issues/153#issuecomment-164223357) to ignore a file that is already present. There is no other way that I know...

> I'm not sure it makes sense to error out of a file you asked to ignore doesn't exist. To clarify, he's suggesting that it error out if the file...

Thanks, @brikis98. It looked something like this: ``` volumes: # comment # comment - # comment # comment - ``` I guess it wouldn't be too hard to recognize comments....

Okay, if I have time, I'll do it. :) By the way, I just noticed that if you pass explicit sync paths using the `-s` option, it still looks at...

(To clarify, it merges these lists, using both the explicitly passed sync paths in addition to what is in the compose file.)

It looks like one prerequisite to doing this is enhancing [`_get_ignore_from_manifest()`](https://github.com/mgedmin/check-manifest/blob/b9a07fbea9c922e65115c6121f942395fc571ecd/check_manifest.py#L453) to return the `include` lines and not just the `exclude` lines. Once that is in place, it should be...

I started working on it to see how much time it would take. :) I will see if I have some time later this week, but not today.

That seems acceptable to me given that the proposal is for a warning rather than an error. For example, if there is a warning that `docs/_build` doesn't exist, I think...

I'll let you know if I encounter any in the future. It's been a while since I filed this, so I can't remember the particular files unfortunately.