Chris Jerdonek

Results 118 comments of Chris Jerdonek
trafficstars

Do you have any idea how many of these compiled expressions are used during startup, and where they are defined? It seems like you could figure this out using your...

Thanks! The reason I ask, by the way, is that there's another alternative, which is not to import modules / code that isn't needed for startup. Like, you could imagine...

I guess for me personally I'd be more interested in reviewing and seeing progress on the more general dependency / import issue. Like, why does pip's startup need to import...

Like, it seems like we shouldn't need to actually import all the command classes here just to get their name and summary in order to parse the command name: https://github.com/pypa/pip/blob/ddfa401dae5cdc473772f93951be2715e852681a/src/pip/_internal/commands/__init__.py#L27-L42...

I filed a separate issue for what I was suggesting: https://github.com/pypa/pip/issues/6692. It's similarly focused and gets more at the root cause IMO as many of the `re.compile` lines will no...

A couple suggestions: * add a few terms around open source (e.g. "open source," "copyleft," etc) * alphabetize the entries

PS - since the glossary is big, it looks like it would be easy to script alphabetizing it (e.g. in Python by splitting on `\n* **`, sorting, and then joining...

I added a script in PR #481. You don't need to check it in if you just want to use it once.

Good point re: case-sensitivity. I half-noticed that but wasn't sure your preference. Done!

No prob! (Btw, FWIW you can also run the script with Python 3, which is what I used.)