Chris Barth

Results 135 comments of Chris Barth

I concur with @krillep . I just tried the daily build again, and, same behavior.

@hipersayanX , I'm not sure what to say. It is clear that I'm not the only one. I can grab some video footage if you'd like, but there really isn't...

Why did you request my review since my previous comment is still open and unaddressed?

This is preferable, but it would at least be helpful to support your own dot-file of settings so that I can commit them and every user of the plug-in will...

I've rebased this PR and make sure all the tests are passing.

LMK if/when you'd like me to review this code.

Unless I'm mistaken, `xpath` shouldn't have an `evaluate()` because it is a method on a `Document` instance. So, first you should get a `Document` instance, then, the type system would...

> I'm able to workaround needing the createNSResolver, by just creating a shape that meets the type requirement: We shouldn't have to work around it. I also think that we...

> Aside from some obscure browser interop situation, I don't think there's any good reason to use `xpath.evaluate` So there would be no need to add that type back in?

> `selectWithResolver`, on the other hand, was just added last week, and I think it should be removed Generally speaking, if it exported, it should be typed. If the type...