Chris Barth

Results 135 comments of Chris Barth

@ergoithz , we'd welcome a PR with a test suite to address this limitation in `xml-crypto`. Would you consider contributing to the community to address this weakness?

@ponyesteves , if you'd be willing to contribute a PR with a test suite, even if that PR is just a better error message, we'd love to have it. Please...

@tngan , that's excellent work! Would you mind creating a PR with at least a test replicating this issue, and perhaps a fix for it. We don't want this to...

@microshine , we'd be more than happy to see a PR with a test suite to address this concern.

@yaronn , @tngan , would you be interested in creating a PR with a test suite to add that functionality to `xml-crypto`?

@jonfairbanks , we'd love to see a PR to address your issue and help you not have to maintain a fork. Please create a PR with a test suite and...

What are you trying to accomplish @ponyesteves ? That might be a question that will get more responses.

Feel free to put up a PR that includes some better documentation about this or that improves the user experience.

@JLRishe , I can make another PR to change this to be just the relevant parts. If you are open to #132 , I'd like to land that first after...

I don't think this is entirely correct. These typing changes result in `select(_, _, false)[0]` returning a `Node` but `select1()` can possibly return `null`. Given that `select1()` is just `select(_,...