Chris Barth

Results 135 comments of Chris Barth

@kaibernhard , I've reviewed your code and made a few comments. The tests are good, but I think they'll fail without @cornzz original changes. Are you proposing that we land...

@cornzz , would you be willing to collaborate with @kaibernhard to include his tests in your PR? He could make a PR against your branch that you could accept and...

@sibelius , yes, there are plans to merge this once it is done. Please feel free to contribute; I can use all the help I can get as recently I...

@sibelius , sorry for not catching all these comments and thank you for your interest in this. It appears that some of the work that @shunkica has done in #506...

@karfau , there are some sample XML over at `node-saml` that are causing the same error, and these XML files seem to meet that requirement of having the namespaces defined...