CL Fisher

Results 1061 comments of CL Fisher

Fixed problem when entering one million items for donation

Back to @dorner for technical comments -- I had a small quibble with the test clause.

Fixed problem when entering one million items for donation

@dorner : it sounds like @GiovannyCordeiro is stuck on this. Can we get a judgement call on whether it's valid to proceed without the test they are having problems with...

If you enter a million of an item in donations and save, a confirmation comes up. It still saves if you press cancel.

Please give it a shot!

If you enter a million of an item in donations and save, a confirmation comes up. It still saves if you press cancel.

I'm going to pass that to @dorner

If you enter a million of an item in donations and save, a confirmation comes up. It still saves if you press cancel.

It looks like @GiovannyCordeiro is still working on this. Reassigning it to them.

[Investigation+] Address "unpermitted parameter" log entries when doing "export distributions"

Done.

#4982 - Add "on the fly" addition of donation sites when entering a donation

It'll probably be Monday before I get to reviewing this.

#4982 - Add "on the fly" addition of donation sites when entering a donation

LGTM functionally. Over to @dorner for technical comments.

#4982 - Add "on the fly" addition of donation sites when entering a donation

Hey @dorner -- it looks to me as if @neenu-chacko made the requested changes, but maybe didn't request a re-review. Can you take a look?

#4982 - Add "on the fly" addition of donation sites when entering a donation

@neenu-chacko Are you still working on this? If we don't hear back in a couple of days, we'll assume that we need someone else to finish this off.