CL Fisher

Results 1061 comments of CL Fisher

Ensuring that the value of the “Total on Hand” column is zero

I believe @GiovannyCordeiro said they have to go quiet for awhile on another issue.

Add packages (not packs) as an option for the distribution export (from Nicole D, 20240807 stakeholder meeting)

Please do.

Add packages (not packs) as an option for the distribution export (from Nicole D, 20240807 stakeholder meeting)

Sure!

Add packages (not packs) as an option for the distribution export (from Nicole D, 20240807 stakeholder meeting)

@brodyf42 -- I would think that a float to 2 decimal places would work.

Add "on the fly" addition of donation sites (we have it for product drives, and manufacturers) when entering a donation

Sure!

Add "on the fly" addition of donation sites (we have it for product drives, and manufacturers) when entering a donation

It's in process of review-and-fix.

Add "on the fly" addition of donation sites (we have it for product drives, and manufacturers) when entering a donation

There's an open PR for this, but the developer has to step away for awhile. What it needs is a rework of some bits from JS ERB to Turbo and...

Add "on the fly" addition of donation sites (we have it for product drives, and manufacturers) when entering a donation

Please do!

Fixed problem when entering one million items for donation

LGTM functionally -- @dorner -- can you give @GiovannyCordeiro some advice on how to build tests for this?

Fixed problem when entering one million items for donation

We don't currently have any tests around the donation confirmation process (which is why we only saw this problem during manual testing). I expect that looking at spec/system/distribution_spec.rb lines 29-56...