rubyforgood
Ensuring that the value of the “Total on Hand” column is zero
Resolves #5004
Description
Bug fix (non-breaking change which fixes an issue)
Type of change
- Changes to the “Itemized donation” and “Itemized distributions” pages by removing “Unknown” to zero
- Tests have been carried out to guarantee this change
How Has This Been Tested?
I ran a test by creating a fictitious donation of five units, followed by a simulated distribution of those same units. In this way, the visualization in the "reports" tab of both windows showed zero, as expected.
Hey @GiovannyCordeiro A process note here -- please avoid force pushes once we've started reviews.
Oh... Sorry @cielf, I just wanted the branch to be up to date with the main branch for revision.
Hrmm @GiovannyCordeiro It looks like there is a test failing that is related to your work.
The error was happening because I didn't set the filter to enter the range of the donation creation I made. Sorry.
But I've fixed it!
Very good! The next step is @dorner's review -- to set expectations, that may take up to 2 weeks due to him being extra busy atm.
Not yet. Unfortunately, I haven't been able to dedicate time to it in the last two weeks. I still need to identify why the test logic doesn't work properly when a code change occurs. I hope to take a look tomorrow. Sorry, @cielf
I believe @GiovannyCordeiro said they have to go quiet for awhile on another issue.