CL Fisher

Results 1061 comments of CL Fisher

[WIP] Partner::AGENCY_TYPES is an enum on Partners::Profile

@veezus Is this still a [WIP]?

[BUG] You can enter an issued_at date without a time. Hijinks ensue.

Hey @MohanThanigaivelan -- I definitely want @dorner's take on this. If we were to go with #1, we'd want to have the same restriction in some other places, for consistency's...

Include period supplies in kits in NDBN report values that are based on period supplies

This is going to be assigned to @jadekstewart3. This comments just here so I can do that. Apparently I actually need Jade to comment on this issue to do that!

Include period supplies in kits in NDBN report values that are based on period supplies

Thank you!

Include period supplies in kits in NDBN report values that are based on period supplies

Hi @jadekstewart3 -- just a heads up that I'm doing some rework of the whole what-goes-in-what-bucket due to conversations with NDBN, and things I've found that were just not right!...

Include period supplies in kits in NDBN report values that are based on period supplies

Noting that that is up and merged -- if you check the scope for period supplies on item in main, you'll see that it is *much* simpler now!

Include period supplies in kits in NDBN report values that are based on period supplies

Hey @jadekstewart3 Checking in on this -- any roadblocks you need cleared?

Include period supplies in kits in NDBN report values that are based on period supplies

@jadekstewart3 I don't have time to dig into it today, but may I ask -- is purchased_kits supposed to be getting the number of kits purchased? Because my first read...

Include period supplies in kits in NDBN report values that are based on period supplies

@jadekstewart3 Oh! The base category name for period supplies is not period supplies, but Menstrual Supplies/Items -- the important part being that we look for menstrual . Still think the...

Include period supplies in kits in NDBN report values that are based on period supplies

@jadekstewart3 Just checking in - do you need anything on this?