rubyforgood
Include period supplies in kits in NDBN report values that are based on period supplies
Summary
Period supply values in the Annual Survey should include period supplies in kits
Why?
Better reporting of actual distribution
Details
Similar to issue #3939... You may need to use SQL to extract the information Look at services/reports/period_supply_report_service Assume 1 kit per individual
The following values in the report will need attention: Period Supplies distributed Period Supplies per adult per month [Note: this should be per individual per month -- confirmed with NDBN liason] % period supplies donated -- note that most banks make their own kits, but we do have some who have kits donated -- so this is a slightly different twist from #3939 % period supplies bought -- afaik, we don't have any cases of kits being bought, but we don't prevent it.
Criteria for completion
- [ ] values in report regarding period supplies reflect period supplies in kits
- [ ] tesets demonstrating the changes
This is going to be assigned to @jadekstewart3. This comments just here so I can do that. Apparently I actually need Jade to comment on this issue to do that!
Just an update: Still working on this. I was OOO the last week an a half, so I am hoping to get some more done this week and next :)
Hi @jadekstewart3 -- just a heads up that I'm doing some rework of the whole what-goes-in-what-bucket due to conversations with NDBN, and things I've found that were just not right! keep an eye on PR # 4361.
There is going to be a rework of what is in period_supplies -- making it depend on the category rather than the partner keys --- it turns out the initialization of the seed and what is in prod had different categories, which explains why someone coded it with the partner keys! The latest on that should (I hope) be up later today, though not merged.
Noting that that is up and merged -- if you check the scope for period supplies on item in main, you'll see that it is much simpler now!
Hi @cielf! Thank you for checking in! I'm actually having some trouble with pulling the purchased items
I should be showing at least one purchased kit based off of this test set up:
This is my method:
The current method is returning zero, and I should be expecting 1. I've been messing with multiple versions of this method, and I cant quite put my finger on why my method isn't returning the integer 1, as expected with the single purchased kit in my test set up.
@jadekstewart3 I don't have time to dig into it today, but may I ask -- is purchased_kits supposed to be getting the number of kits purchased? Because my first read of that is that it might get the number of line items with kits purchased -- that being said, I'll have to sit down with it and figure out each step. Probably tomorrow.
@jadekstewart3 Oh! The base category name for period supplies is not period supplies, but Menstrual Supplies/Items -- the important part being that we look for menstrual . Still think the method might not be giving what you expect it to. though.
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@cielf I'm almost done with this, i do have a question though. When you are asking for % of period supplies bought, you want me to pull the number of supplies contained in purchased kits, right?
I'm not sure anyone ever purchases kits, but/and it's still correct to take them into account. You did for the disposables, right? We should be consistent across the 3 broad categories.
I checked -- there are a few purchases of kits in the production db. Very few, but that does mean the answer is yes.
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.