CL Fisher
CL Fisher
Hey @dorner -- Just checking if you have any last comments on this -- you've chimed in, but more on a problem solving than critiquing the code pov. Thanks!
I should probably take this out for one last spin before we merge it. [Edit: Actually -- no -- if it's only comment removal, I don't need to.]
Holding off on the merge until the release of April 7 is done.
@elasticspoon Looking at the analogous behaviour for distributions, purchases, and donations, the behaviour shown in the quantity request is consistent with that. I'd like to check in with the core...
Core team meets Sundays, so don't expect a full answer before then.
Notes another inconsistency -- the item field on the quantity request shows "Select an item", whereas the individual is just blank. On the bank side we show "Choose an item"
Ok... The answer is that we should be giving an error in these cases. Thank you for your patience.
The case we're talking about is that they have an item chosen, but no quantity. Pretty sure #2489 is covering cases where no item is chosen.
Ah, I somehow thought you were saying that Item filled in but number not filled in on quantity was removing the row silently, which is currently happening on donations (making...
It is. I would add it under the "Issued to:" section. There's room there, and the flow works.