CL Fisher

Results 1061 comments of CL Fisher

The question is, then, whether, if it works with read_events on, should we go ahead with the change, or just let it be until the read_events is on for everyone.......

Ok... we should have a test that shows that it works properly for the 0 case, IMO. Why we don't -- an error in judgement by a past reviewer, I...

It should also make any effort to speed up the things easier -- and a couple of the reports desperately need some speeding up.

@awwaiid does this apply across all the bits we are putting under reports with dashboard, or is it just the annual report?

@dorner Hrm. On my local, If you upload a file, and have counties not adding up to 100, and hit save, you, of course, get an error (as you should),...

So... if I understand correctly, we would be in a better place than we originally were if we put this in without "chasing this bug". Given that, I say let's...

@awwaiid Can you take a look at this one, please?

Noting for @awwaiid 's benefit that we are going to have to communicate to the affected banks when this goes out

But wait! What about the historical trends graph?

> But wait! What about the historical trends graph? I don't think they use inventory.