CL Fisher
CL Fisher
Hey @jadekstewart3 I'm running to the end of my work on this for today -- but is this back in a "ready for review" state?
Hrm. I just did a light manual test on this as follows: 1/ create a distribution with 50 of 2 different items in it that are classed as disposable diapers,...
@jadekstewart3 I'll try to kick the tires on this tomorrow -- the suggested sql looks like it should work to me! Rubocop is complaining, though -- if you have the...
> @cielf Hi! I did have to fiddle with the query a bit, but it is returning an integer (YAY!) 😀 It is calculating non disposable items as well, I...
Hrm. I put together a distribution that had a disposable item and a kit with disposable items for testing, and the report only seemed to count the disposable items --...
@dorner -- brakeman thinks there is a SQL injection issue with the query -- can you speak to that? I'll try to kick the tires on this today or tomorrow.
@jadekstewart3 Hmmm.... doesn't seem to be including the kits in. Here's the sequence I tried. From a fresh seed: 1/ check the disposable diapers in the 2023 report - call...
(Pokes into the code a bit) Looks like you might only be using the magic SQL for the children served service, and not for the aquisition_report_service. That would explain it.
Hey @jadekstewart3 -- did you look into adding in a clause to in your sql to make sure that the itemizable type for the kit line items is kit?
It passes my functional test (adding a mixed diaper and kit-with-diapers distribution) with flying colours! Hurrah!