Chuck Carpenter comments

Results 54 comments of


                                            Chuck Carpenter

HTML reporter now no longer works with browserify-istanbul in v4.0

Thanks for the solution branch for this @SpenceDiNicolantonio. That helps a lot. :+1:

HTML reporter now no longer works with browserify-istanbul in v4.0

Sure, we're doing this with the fix branch installed: ``` javascript const istanbul = require( 'browserify-istanbul' ), isparta = require( 'isparta' ); module.exports = function( config ) { config.set( {...

Fix overlay not shown after tour complete/cancelled

@rwwagner90 this is an edge case and getting stale. I suggest we close it and happy to take a new PR based on your suggestions if @Rzr7 would like.

noop when SSR

Seems like something as simple as `const isServerSide = typeof window === 'undefined'` and then a noop return if true.

noop when SSR

@rwwagner90 that's how Next.js does the SSR check, seems to work for them.

noop when SSR

@rwwagner90 perhaps just in the Tour constructor?

noop when SSR

@EmNicholson93 anything else you'd need to start this one?

Add initial docs and example on testing with Playwright

Committed suggestion, so back to you @tony-sull

Write tests for all examples

@rwwagner90 what is `facebook`?

getScrollParents util can push "null" as sole scroll parent when body has not been rendered, causing fatal error

I can definitely see a clear use case where this wouldn't create a Tether until `BODY` was available. I'd be open to either a polling function or Mutation Observer option...