shepherd
shepherd copied to clipboard
shepherd-pro
Fix overlay not shown after tour complete/cancelled
Overlay is not appearing again if tour was completed/cancelled.
Bug reproduction steps:
- Start tour with
useModalOverlay: trueoption - Complete tour
- Try to show any step using
tour.show()
Solution:
If modal container removed - remove modal object too. Otherwise modal container not appearing again.
@Rzr7 I don't think we intended to be able to call show without calling start first. You would bypass a lot of logic that way.
@Rzr7 I don't think we intended to be able to call
showwithout callingstartfirst. You would bypass a lot of logic that way.
I was calling show using dropdown "help" list, so I was needed to show only one tour step.
@Rzr7 I believe instead of your changes we should do this._setupModal(); on show if the modal doesn't already exist or something. Basically making sure all the logic from start gets called if show is called before start for some reason.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rwwagner90 this is an edge case and getting stale. I suggest we close it and happy to take a new PR based on your suggestions if @Rzr7 would like.
@chuckcarpenter I did take a look at implementing a fix for this and didn't fully have the time to devote to it. Would love to work with you and/or @xiwcx and see if we can come up with a good fix.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.