Andreas Thomas

Results 395 comments of Andreas Thomas

Oh and while we are at it: The `offset` is optional for almost all write methods. Should I change those too?

I just went ahead and matched the optional offsets to the official node implementation. @feross Can you please review it.

Hmm, v1.3.0 or older might still work. But I'm not 100% sure. I won't have time this week but I'll add it to my todo list.

Hey @dthyresson The @upstash/redis api is not compatible with ioredis, because we wanted to provide a nicer typescript experience, however it would be pretty easy to write a small adapter....

Hey @dthyresson I've created a draft PR #1404 Maybe you can try and figure out why the tests are not working yet. I'll retry as well sometime this week.

Hmm, we're not doing anything other than calling `JSON.parse` when deserializing. I'm not sure what's causing this but I'll try it myself. Yeah, can you try it without deserialization: ```ts...

Thanks, I will try to debug this asap, but I can't promise you anything until the end of next week.

Hey @cathykc I did some more testing and I belive it is actually the `JSON.stringify` method, that causes the issue. The easiest way around that is to escape the backslashes...

I'll close this due to inactivity, please reopen if you have more questions