buffer icon indicating copy to clipboard operation
buffer copied to clipboard

Published 20 hours ago • verified publisher icon feross

Fix `write{U}Int{LE,BE} types

Open chronark opened this issue 4 years ago • 2 comments

They should take a BigInt as parameter and return the written bytes as regular number, right?

At least that's what it actually does :)

chronark avatar Dec 10 '20 12:12 chronark

Oh and while we are at it: The offset is optional for almost all write methods. Should I change those too?

chronark avatar Dec 10 '20 12:12 chronark

I just went ahead and matched the optional offsets to the official node implementation. @feross Can you please review it.

chronark avatar Jan 11 '21 13:01 chronark

any chance this will be merged soon?

mistermoe avatar Oct 13 '23 22:10 mistermoe

@chronark can you restore this fork? I can't merge as you have deleted your fork, but I am happy to merge the changes. If you can't easily do that, I'll open a new pull request with the changes bundled and ensure attribution is kept in some manner.

dcousens avatar Oct 14 '23 01:10 dcousens

See https://github.com/feross/buffer/pull/334

dcousens avatar Oct 14 '23 01:10 dcousens