Christoph Herr

Results 28 comments of Christoph Herr

I created a working nuxt version here: https://github.com/christophherr/npm-stats/tree/nuxt Meta and Analytics need work (e.g. setUrl() ) but I wanted to hear if this is going in the direction you had...

The $content_width is defined in https://github.com/Getbeans/Beans/blob/development/lib/render/template-parts.php#L243 I tested a Youtube embed and it is resizing. We are, however, not declaring theme support for [responsive embeds]( https://wordpress.org/gutenberg/handbook/extensibility/theme-support/#responsive-embedded-content).

@Tsquare17 We're not declaring any of the "Gutenberg theme supports". For wide and full images we have to add `add_theme_support( 'align-wide' );`

More details in the GB handbook: https://wordpress.org/gutenberg/handbook/designers-developers/developers/themes/theme-support/

I'd like to hear more about the benefits and disadvantages of browser-side compiling vs. server-side compiling. E.g. performance, security, reliability, error handling, supporting documentation,...

Just listing a few examples of adding AMP support ``` https://github.com/Automattic/_s/pull/1286 https://github.com/xwp/wordpress-develop/pull/307 https://github.com/wprig/wprig/search?q=amp&unscoped_q=amp ```

@ibes Not quite. Theme support will be added for all the items listed in the array. The keys with the `null` value, don't take a configuration. (See the DocBlock explanation)...

Looks like we need to add an explicit height to `audio` maybe something like ```[css] .wp-block-audio audio { height: 50px; } ``` And if you want it centered, ```[css] .wp-block-audio...

@paaljoachim Thank you for testing all the things Gutenberg. I'm not sure about this specific issue but I'd say we have to add some general Gutenberg styling/support to the framework.

Hey @Tsquare17, What does this change fix? What is the benefit of this change? What could break from this change?