Beans icon indicating copy to clipboard operation
Beans copied to clipboard

Make Beans AMP-compatible out-of-the-box.

Open hellofromtonya opened this issue 6 years ago • 3 comments

Let’s make Beans AMP ready as part of the progressive theming initiatives. This change will require us to:

  1. integrate AMP tags into the HTML
  2. add the theme support add_theme_support( ‘amp’ );
  3. audit the compiled assets file sizes

hellofromtonya avatar Jun 15 '18 00:06 hellofromtonya

Just listing a few examples of adding AMP support

https://github.com/Automattic/_s/pull/1286
https://github.com/xwp/wordpress-develop/pull/307
https://github.com/wprig/wprig/search?q=amp&unscoped_q=amp

christophherr avatar Jun 21 '18 19:06 christophherr

We'll have some work to do for integrating AMP tags into the HTML. Here are some examples of AMP-compatible themes:

Here are some talks on AMP by Alberto (Google) and @ThierryA:

Drum roll please...one of the leads to AMP and WordPress is our founder, @ThierryA! Cool!

hellofromtonya avatar Jun 21 '18 19:06 hellofromtonya

I try to understand what AMP in the theme would mean. Have not worked with AMP so far.

This looks interesting: Pull request to make the standard themes AMP ready. AMP for WordPress required the Plugin for WordPress, right?

https://github.com/xwp/wordpress-develop/pull/307/commits/3975dabbb92ffe96fd7653912429d4f852b91b74

https://github.com/xwp/wordpress-develop/pull/307/commits/908bd6944953a691d4b7e36934c9c78ddb5a091d

What new requirements will the CSS, JS, HTML etc. will get through wanting to support AMP?

ibes avatar Jun 22 '18 21:06 ibes