Christoph Fröhlich
Christoph Fröhlich
Ad odometry of ackermann steering: There is a not negligible error imho. (average is the equation implemented in the library, plotted for l = 1, w = 1; the equation...
> Impressive job! I think this is very valuable. At least for now everything seems ok to me, I would maybe suggest to be more explicit in the derivation of...
Am I right that for a trailing steering axis (`front_steering=false`) one has just to use a negative value for the wheel-base `l`, and that's it?
> Very nice @christophfroehlich this looks like a very good documentation page! Nice work! Looks alright to me. IMHO I would finish and merge this PR. The documentation page will...
> > > > > Thanks for polishing this out, but I still ask for some description/documentation of the simple_joint_limiter 🙊 > > No problem, how would you like to...
RHEL workflow fails because generate_parameter_library seems to be not released for RHEL: [ _This project is currently disabled_](https://build.ros2.org/job/Rbin_rhel_el964__generate_parameter_library__rhel_9_x86_64__binary/) @tylerjw was this disabled on purpose? To fix this here, shall we...
Ad #940: Can it be that it was forgotten to update the documentation https://github.com/ros-controls/ros2_control/blob/db34dfaf2d79fc8afcd460d9ae16f02c43265a2a/controller_manager/doc/userdoc.rst?plain=1#L58-L60 according to this deprecation warning? https://github.com/ros-controls/ros2_control/blob/db34dfaf2d79fc8afcd460d9ae16f02c43265a2a/controller_manager/src/controller_manager.cpp#L162-L166
Is it feasible to do that in `on_activate` instead of `on_configure`? Our current best-practice is afaik - declare parameters in the `on_init` - parse all parameters and check read-only parameters...
> Hey folks! Thanks again for all your hard work on this. I was just curious, do you know if this feature improvement is still expected to be released in...
@bence @destogl Let's merge this and then https://github.com/ros-controls/control.ros.org/pull/262 to put the migration notes on the top level of the docs.