Christoph Fröhlich
Christoph Fröhlich
What is missing in your opinion? ament_copyright only complains about a missing CONTRIBUTING.md file
but this repo only hosts message definitions, and I never saw copyright notices in *.msg files?!
Where do you have this information from? ament_copyright expects exactly that file: https://github.com/ament/ament_lint/blob/rolling/ament_copyright/ament_copyright/template/bsd_3clause_license.txt
Recently we used something like `Copyright 2024 ros2_control Development Team`
I support the idea of a base implementation without ROS, and then being wrapped in the filters-class with the ROS node interfaces. @roncapat Even if your idea is a few...
Sorry for the late reply. I see two options: - Use a consistent nomenclature and break API with Jazzy (we would have to branch this repo then) - Deprecate the...
> BTW, why are there no 'humble', 'iron', 'rolling' branches and so on in this repo? because the ros2-master branch is released to all distros, there was no need for...
> @christophfroehlich Just a note about the CI. Interestingly I just had the case that pre-commit in the CI failed but did run sucessfully on my system. (Note about using...
> I would also be happy to provide some documentation on how to use this implementation but I am not sure where in the repository it should go. We don't...
> EDIT: One question regarding the copyright notice for the existing tests. How should this be handled? At the moment I didn't copy any of it to the merged file....