Christopher Man comments

Results 20 comments of


                                            Christopher Man

vscode can't open file when file's name contains zero width chars.

@bpasero picking this up and working on it now, & will have all unit tests completed.

vscode can't open file when file's name contains zero width chars.

I created a branch of this repository and working on this issue, I think I have found the issue with the naming convention found within encoding.ts. There seems to be...

vscode can't open file when file's name contains zero width chars.

Followup, The bug that I found and fixed works on my local dev branch. We'll complete all unit tests to make sure this works, and then we'll submit a PR...

vscode can't open file when file's name contains zero width chars.

The fix worked and it now renders utf-8-bom encoded filenames !

vscode can't open file when file's name contains zero width chars.

The above only works when you open the file directly. The issue very much still persists if you open up the file from the file tree. Clearly this is an...

vscode can't open file when file's name contains zero width chars.

@bpasero @albertosantini The bug is actually a lot more complex than I initially thought. I have found a related issue above, somewhat for a workaround for non-normalized paths, which I'm...

vscode can't open file when file's name contains zero width chars.

Update: making great progress on this issue, took me some time to map through mentally how the entire file explorer works. Learned significant amount about IPC we use but focusing...

vscode can't open file when file's name contains zero width chars.

## Update I've identified specifically how we make read directory calls, I initially thought we would make system calls per OS but I see its easily handled via NodejS. Within...

vscode can't open file when file's name contains zero width chars.

## Update - After running a debugger through all of `pfs.ts` which `readdir()` and `stat()` utilise for async promise file system calls; - I can result that the BOM is...

vscode can't open file when file's name contains zero width chars.

### Update - I've actually identified where the issue is finally ! #### The Real Problem - When `child.name` contains a BOM character, it causes issues in: - `joinPath(resource, child.name)`...