Christian Lent

Results 12 comments of Christian Lent

Thank you so much for reporting this! I was just trying this image for the first time today and noticed that I couldn't scan my local files.

Thanks for the feedback! Let me address your core feedback first. I may make an attempt at refactoring some existing functionality, but my time is running low to work on...

Nevermind, "validValues" is not a great refactor candidate.

OK, I addressed at least some of your feedback, but I haven't yet had time to refactor any existing functionality using the custom validators. I did add an "options" parameter...

Anything I can do to help this along? I may have some time this weekend if that's what it needs to be completed.

Hmm, good question. Unfortunately, I haven't yet. I'll take a look next time I have a free weekend. It's definitely a worthy goal. Supposing I actually refactored some, and merely...

I'm sorry, I got very busy again! I'll try to take a look this weekend. Still loving h5Validate BTW.

Let me know if there is anything else I can do to move this along. I'm looking forward to your comments on the changes!

I completely understand and there's certainly no need to apologize! I'm grateful for the work you've already put into the library, and I've personally found it indepensible in one of...

As soon as this pull request has unit tests, I would be more than happy to refactor this into the unified validator model from https://github.com/ericelliott/h5Validate/pull/87 . It would make it...