h5Validate icon indicating copy to clipboard operation
h5Validate copied to clipboard

Published 20 hours ago • verified publisher icon ericelliott

added min and max validation [Fixes #90]

Open gruberb opened this issue 10 years ago • 9 comments

gruberb avatar May 06 '14 15:05 gruberb

fixed the comments

gruberb avatar May 07 '14 15:05 gruberb

Do we have unit tests for this?

ericelliott avatar May 15 '14 06:05 ericelliott

[#90]

ericelliott avatar May 15 '14 06:05 ericelliott

As soon as this pull request has unit tests, I would be more than happy to refactor this into the unified validator model from https://github.com/ericelliott/h5Validate/pull/87 . It would make it a bit cleaner (the min/max logic would be a little more contained). I definitely love the idea of h5Validate having this capability.

christianlent avatar Aug 18 '14 13:08 christianlent

Any progress on this, guys?

ericelliott avatar Jan 04 '15 10:01 ericelliott

I really haven't looked at this since my last comment, but I'm confident that it would fit nicely into the new validator model in #87 . As soon as you've dealt with unified validators one way or another, I can look into this (including perhaps adding some unit tests?).

christianlent avatar Jan 04 '15 17:01 christianlent

Honestly, I'm so buried in my current work, it may be a very long time before I have time to deal with it. Would you be interested in becoming the official maintainer of h5Validate?

Ideally, every commit will still go through the PR process, and somebody else should at least have the chance to pull down the PR, run the unit tests, and look at the code changes.

ericelliott avatar Jan 04 '15 18:01 ericelliott

Perhaps, or at least maybe just pick up the slack for as long as you're over-committed.

christianlent avatar Jan 05 '15 02:01 christianlent

@christianclent Would you be interested in leading a rewrite project?

ericelliott avatar Jan 06 '15 16:01 ericelliott