Results 14 comments of Chris Mytton

@dracos Thanks for doing the fixes for this (and deploying them to the live site!) 🙂 I think any further changes are probably best done in separate PRs, so going...

> Probably fine, could have done with another rebase first to check :) I did a rebase, there were no conflicts and the tests all appear to pass, phew!

Note that now https://github.com/mysociety/fixmystreet/pull/3494 has been merged the `roles` table also has an `extra` column that uses RABX.

Oh and I think rebasing this branch onto lastest master should hopefully fix the test failures!

> I did find the having to tick the assigned categories only box for the role categories to apply a bit non intuitive Yeah. I'm going to leave it like...

Thinking about it I should probably add some documentation about this to the manual so people know how to use this feature.

Bromley want to restrict which categories a user with a certain role can _create_ reports in, as well as view reports in. I've added an extra Bromley-specific commit which hides...

Bromley came back and said they were happy with how this is working except for this error message that appears: ![image](https://user-images.githubusercontent.com/22996/136064379-57f8458e-0355-4cbf-867e-d35c870296e3.png) After a bit of digging it turns out this...

> I wondered if contacts (the second argument) should be reduced similarly, it's not totally clear what that then might be used for, but I don't think it matters if...

Bromley have requested that TfL categories are always displayed, regardless of the current user's role category restrictions. I've pushed 02c92948a916363f076ad5b2c54d0a9ec693855a to fix this. @dracos would you mind checking my fixup?