fixmystreet icon indicating copy to clipboard operation
fixmystreet copied to clipboard

[Bucks] Add email alternative to templates

Open MorayMySoc opened this issue 2 years ago • 4 comments

  • Adds setting to allow email alternative text to be added
  • Filters out alerts that need to send the email text from general alerts of added comments
  • Update database with new fields
  • Create email templates for email template text
  • Updates documentation to include template email text

https://github.com/mysociety/societyworks/issues/2817

MorayMySoc avatar Jul 04 '22 14:07 MorayMySoc

Codecov Report

Merging #4001 (297465d) into master (edec516) will decrease coverage by 9.12%. The diff coverage is n/a.

:exclamation: Current head 297465d differs from pull request most recent head 6d2795b. Consider uploading reports for the commit 6d2795b to get more accurate results

@@            Coverage Diff             @@
##           master    #4001      +/-   ##
==========================================
- Coverage   82.82%   73.69%   -9.13%     
==========================================
  Files         362       55     -307     
  Lines       25270     4760   -20510     
  Branches     3809        0    -3809     
==========================================
- Hits        20929     3508   -17421     
+ Misses       3154     1252    -1902     
+ Partials     1187        0    -1187     
Impacted Files Coverage Δ
...llib/FixMyStreet/App/Controller/Admin/Templates.pm
perllib/FixMyStreet/DB/Result/Comment.pm
perllib/FixMyStreet/DB/Result/ResponseTemplate.pm
perllib/FixMyStreet/Queue/Item/Report.pm
perllib/FixMyStreet/Script/Alerts.pm
perllib/FixMyStreet/Template.pm
perllib/Open311/UpdatesBase.pm
perllib/Utils.pm
perllib/FixMyStreet/App/Form/Wizard.pm
perllib/FixMyStreet/Cobrand/EastSussex.pm
... and 297 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 04 '22 14:07 codecov[bot]

I've added an email_text column to the comments and removed the extra_data stuff. I've also removed the cobrand specifics. I have left the separate template in as I think that it is a different style of email as we discussed, but happy to reconsider. Also added that these emails should go to the reporter and any subscriber should continue to receive the subscription list - which I think is working. Added a test which makes me think it it anyway!

MorayMySoc avatar Jul 15 '22 10:07 MorayMySoc

Oh and I think rebasing this branch onto lastest master should hopefully fix the test failures!

chrismytton avatar Jul 25 '22 15:07 chrismytton

@dracos This latest commit to answer feedback on the FD ticket

MorayMySoc avatar Aug 03 '22 16:08 MorayMySoc