Chris Krycho

Results 765 comments of Chris Krycho

Yeah, I like that as a path forward.

Seems perfectly reasonable to me. We’d just want a nice configurable switch for that if it’s ending up in the vendor bundle, or (better?) to deliver it separately.

Following up on this (as I'm poking at some related things): - If we want a "ponyfill" that supplies native if it exists or a polyfill if not, that's fine,...

Ah, perfect – I was going to ask about exactly that, @ef4. Net, @asakusuma we can leave the existing nonsense in place for now, but have the new implementation just…...

Thanks for the quick reply! I think adding docs would help a bunch, and I can author a PR to that effect early next week if you like. I also...

Monkey-patching `fetch` like this is, from my POV, an absolute non-starter, but others on Framework may disagree. (I know it's "just JS" but I *loathe* things which patch globals.) My...

This will require using `await import()` if we keep the ember-try config a CJS module, or switching the ember-try config to be an ES module

Please do! I think we are broadly aligned that this is good.

Doing some triage; do we still want/feel the need for codemods? I expect the answer is likely *yes*, and likely to get much louder now that we're hitting 1.0—the swaths...

Clarification—I *believe* this works correctly for local paths, based on this code: https://github.com/typed-ember/glint/blob/3b0d3ab78765c2b39e25e09788597609740cacad/packages/core/src/config/loader.ts#L79 If I'm understanding correctly, both from that repro and from our discussion in chat, the issue is...