ember-test-helpers icon indicating copy to clipboard operation
ember-test-helpers copied to clipboard
verified publisher icon emberjs

Upgrade `registerHook` and `runHooks` as official public APIs

Open drewlee opened this issue 3 years ago • 4 comments

The helper hooks API was initially implemented in a "semi-private" fashion as part of a pilot. However, it's been in use for several years now and has proven to be quite useful (leveraged by ember-a11y-testing) and stable. This warrants exporting them as official public APIs in @ember/test-helpers. It would also allow for exposing the TypeScript types associated with the helper hooks.

CC @scalvert and @rwjblue for awareness.

drewlee avatar Feb 23 '23 19:02 drewlee

I can help put up a PR for this if there are no major objections.

drewlee avatar Feb 23 '23 19:02 drewlee

Please do! I think we are broadly aligned that this is good.

chriskrycho avatar Feb 23 '23 19:02 chriskrycho

Thanks, @drewlee! Much appreciated!

scalvert avatar Feb 24 '23 17:02 scalvert

Addressed via PR #1344

drewlee avatar Mar 03 '23 01:03 drewlee

These are now documented in API.md!

NullVoxPopuli avatar Aug 20 '24 14:08 NullVoxPopuli