Chris Kilding

Results 138 comments of Chris Kilding
trafficstars

The section in question is ``` if (str.startsWith(canonicalPrefix)) { return Pattern.compile(canonicalPrefix, Pattern.LITERAL) .matcher(str) .replaceFirst(""); } else { return str; } ``` Off the top of my head I can't think...

Yep, multiple prefixes in a list would be a reasonable way of doing it. Let's rustle up a PR...

Here's a couple of options for the design... ## Allow the `removePrefix` strategy to accept regexes This is the smallest change. However it may be unintuitive to read, because even...

Any thoughts on the above?

Fortunately the name transformer interface is polymorphic, so we can have as many implementations as we like. I'm starting by adding a non-regex "Remove Prefixes" implementation in #233, which will...

I've been thinking about this for a bit... The first thing to note is that if you need to pass a secret string to a build, by far the better...

I believe that it might be as simple as passing your text file secret as the `--secret-binary` argument rather than the `--secret-string`. Could you try running ``` aws secretsmanager create-secret...

I did experiment with using secret ARNs as credential IDs, but found that credential listing or binding was unreliable. Sometimes secret retrieval failed, and since Moto won't let us simulate...

You can retrieve secrets from other accounts if you do an `sts:assumeRole` first, and then reference the resource by full ARN (not just its name) when fetching it. So it's...