Chris Kilding

The current design is a backwards-incompatible replacement. It adds `SMTPAuthentication#credentialsId` and the surrounding Credentials lookups/UI logic. It removes the `SMTPAuthentication#username` and `SMTPAuthentication#password` fields, and their accessors. As such it would...

Makes sense. I've got a potential config data migration coming up in a different plugin and have been thinking about how best to test it. Migrations are a fact of...

I'm in the middle of adding the migration code, and have come across a couple of issues: - While we have the legacy values to populate a new `StandardUsernamePasswordCredentials` instance...

I've now added migration code that will attempt to create a credential with a random ID from the legacy username and password fields. It specifically tries to save it to...

@alecharp would you be able to take a look at this? If I can get a resolution to the questions, I can rebase it and get it ready to merge.

Hi @alecharp, I've rebased it and caught up with recent changes. The 4 failing tests call `authentication.getUsername()` and `authentication.getPassword()`, which in turn just reflect the value of the deprecated `username`...

@alecharp could you take a look at this?

Could you let me know how you uploaded the file credential to Secrets Manager? Also did you upload it in binary format? (This is very important for the file credential...