Chris Kilding

I was about to restore the old code when I realised there would be another problem. This plugin is both a CredentialsProvider and a SecretSource. The SecretSource implementation runs early...

@DimaNevelev If you're still watching this, a few things have changed... First, the SecretSource implementation was extracted into its own plugin. Second, a new Client configuration feature has been added...

@kuntalkumarbasu I believe you've asked for multi-account lookup in the past. Some new features in the plugin enable secrets lookup into a different account. Would you be able to play...

@kuntalkumarbasu any progress on this?

I've written a test case for this here: https://github.com/jenkinsci/aws-secrets-manager-credentials-provider-plugin/pull/206 Unfortunately I am unable to reproduce the error, as the test has worked just fine. Would you be able to take...

The Secrets Manager provider isn't the only plugin in the chain, so I'm just wondering if maybe the URL encoding handling is going wrong upstream... Could you try creating a...

Yes, we'll need to go digging in the default credential provider code to see if it has special handling for `/` characters. Not only to see what they did, but...

This is the bit of credentials-plugin that causes the validation warning you saw: ```java public final FormValidation doCheckId(@ContextInPath ModelObject context, @QueryParameter String value) { if (value.isEmpty()) { return FormValidation.ok(); }...

If I had to guess, I imagine it was added as a basic 'sanitise your inputs' (OWASP bread and butter secure coding) measure. In that school of thought, the fewer...

Yes, credentials-api is the plugin that contains the credentials interfaces, which credentials consumers interact with. credentials-plugin, aws-secrets-manager-credentials-provider-plugin and so forth contain the concrete providers which implement those interfaces.